gh-144162: Allow for subclasses of a dataclass to define required fields when a parent has defined optional fields #133168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
ZeroIntensity
requested changes
Apr 29, 2025
There was a problem hiding this comment.
Hi, I'd suggest looking at the devguide for the pull request tutorial.
A number of things I'd like you to change here:
- Please move the test to somewhere in the existing dataclass tests.
- This needs a blurb entry per the bot, but also needs a whatsnew entry for 3.14.
- The title should be in a
gh-NNNN: quick summaryformat.
The test is failing, FYI!
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Also, please give this a better title. I didn’t notice it in my inbox. Thanks! |
AA-Turner
changed the title
|
Still needs a better title, I just copied the one from the issue. A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for gh-144162
gh-133162: Allow for subclasses of a dataclass to define required fields when a parent has defined optional fields