Skip to content

Remove redundant incref of immortal object Py_EMPTY_KEYS #133200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

Remove redundant incref of immortal object Py_EMPTY_KEYS #133200

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48a2b01
Remove redundant incref of immortal object Py_EMPTY_KEYS
biglizards Apr 30, 2025
cea7e26
add assert that Py_EMPTY_KEYS is immortal
biglizards Apr 30, 2025
433dfbb
Merge branch 'main' into remove-pointless-incref
biglizards Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4853,7 +4853,7 @@ dict_new(PyTypeObject *type, PyObject *args, PyObject *kwds)

d->ma_used = 0;
d->_ma_watcher_tag = 0;
dictkeys_incref(Py_EMPTY_KEYS);
// We don't inc ref empty keys because they're immortal
d->ma_keys = Py_EMPTY_KEYS;
d->ma_values = NULL;
ASSERT_CONSISTENT(d);
Expand Down
Loading