Apply 'mod' role to typing module #133201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rffontenelle
requested review from
AlexWaygood and
JelleZijlstra
as code owners
bedevere-app
bot
added
awaiting review
docs
|
Could we use rather than Otherwise Sphinx will add a link that just takes the reader to the page they're already on, which seems annoying/distracting |
AlexWaygood
added
skip issue
topic-typing
needs backport to 3.13
AA-Turner
reviewed
Apr 30, 2025
AlexWaygood
approved these changes
Apr 30, 2025
|
Thanks @rffontenelle for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 30, 2025
(cherry picked from commit 2b67db7) Co-authored-by: Rafael Fontenelle <[email protected]> Co-authored-by: Adam Turner <[email protected]>
|
GH-133217 is a backport of this pull request to the 3.13 branch. |
AA-Turner
added a commit
that referenced
this pull request
Apr 30, 2025
Apply 'mod' role to typing module (GH-133201) (cherry picked from commit 2b67db7) Co-authored-by: Rafael Fontenelle <[email protected]> Co-authored-by: Adam Turner <[email protected]>
|
I found the title of Shoud we use like other modules? I did it in #133283. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To highlight the fact that "typing" is the module name, which e.g. would reduce the chance of an incorrect translation when translating Python docs.
📚 Documentation preview 📚: https://cpython-previews--133201.org.readthedocs.build/