gh-131747: ctypes: Deprecate _pack_ implicitly setting _layout_ = 'ms' #133205
+115
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 85cee9f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133205%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
@ZeroIntensity, would you mind doing a quick review? |
ZeroIntensity
approved these changes
May 5, 2025
Comment on lines
+343
to
+344
| if MS_WINDOWS: | ||
| warn_context = contextlib.nullcontext() |
There was a problem hiding this comment.
Why not just skip the test on Windows?
There was a problem hiding this comment.
We want to this to work everywhere (but warn only on non-Windows).
Co-authored-by: Peter Bierma <[email protected]>
|
|
That failure was a timeout; the next builds passed. |
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
… = 'ms' (pythonGH-133205) On non-Windows, warn when _pack_ implicitly changes default _layout_ to 'ms'. Co-authored-by: Peter Bierma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the silent layout switch, plan removal in 3.19 as per PEP 387.
Leave Windows alone; there's plenty of Windows-only ctypes code where this would just be noise.
📚 Documentation preview 📚: https://cpython-previews--133205.org.readthedocs.build/