Skip to content

[3.14] GH-131769: fix detecting a pydebug build of the build Python when building for WASI #133219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 22, 2025
Merged

[3.14] GH-131769: fix detecting a pydebug build of the build Python when building for WASI #133219

merged 6 commits into from
May 22, 2025

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Apr 30, 2025 •
edited by bedevere-app bot
Loading

@brettcannon brettcannon self-assigned this Apr 30, 2025
@brettcannon brettcannon added the build The build process and cross-build label Apr 30, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 30, 2025
Closed
@brettcannon brettcannon marked this pull request as ready for review April 30, 2025 17:24
brettcannon
brettcannon commented Apr 30, 2025
View reviewed changes
Copy link
Member Author

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should NOT be merged until #131770 is resolved.

@brettcannon brettcannon mentioned this pull request Apr 30, 2025
Closed
freakboy3742
freakboy3742 approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks like a good improvement to me.

@brettcannon brettcannon changed the base branch from main to 3.14 May 13, 2025 16:06
@brettcannon brettcannon changed the title GH-131769: fix detecting a pydebug build of the build Python when building for WASI [3.14] GH-131769: fix detecting a pydebug build of the build Python when building for WASI May 13, 2025
@brettcannon brettcannon mentioned this pull request May 22, 2025
Merged
@brettcannon brettcannon enabled auto-merge (squash) May 22, 2025 21:43
@brettcannon brettcannon merged commit 8f4bf15 into python:3.14 May 22, 2025
52 checks passed
@brettcannon brettcannon deleted the 131769-wasi-pydebug branch May 22, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees

@brettcannon brettcannon

Labels

build The build process and cross-build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brettcannon @freakboy3742