Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented May 2, 2025

I tested that all 4 commands now work:

  • make clean && ./configure --with-pydebug --without-doc-strings && make && ./python.exe -OO -m test test_descr
  • make clean && ./configure --with-pydebug --without-doc-strings && make && ./python.exe -m test test_descr
  • make clean && ./configure --with-pydebug && make && ./python.exe -OO -m test test_descr
  • make clean && ./configure --with-pydebug && make && ./python.exe -m test test_descr
Снимок экрана 2025-05-02 в 15 36 58

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn sobolevn enabled auto-merge (squash) May 2, 2025 12:51
@sobolevn sobolevn added the needs backport to 3.13 bugs and security fixes label May 2, 2025
@sobolevn sobolevn merged commit ba16ba3 into python:main May 2, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 2, 2025

GH-133298 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 2, 2025
sobolevn added a commit that referenced this pull request May 2, 2025
…H-133294) (#133298)

gh-133210: Fix `test_descr` in `--without-doc-strings` mode (GH-133294)
(cherry picked from commit ba16ba3)

Co-authored-by: sobolevn <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants