Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented May 2, 2025

@tomasr8
Copy link
Member

tomasr8 commented May 2, 2025

What would be even better is not having a global variable at all, though that would be a larger change and is already partially covered by #10875 I believe.

@StanFromIreland
Copy link
Member Author

We can just clear it for now, till the larger change is merged.

@StanFromIreland
Copy link
Member Author

Also request @serhiy-storchaka

@merwok merwok requested a review from serhiy-storchaka May 2, 2025 20:03
@merwok
Copy link
Member

merwok commented May 2, 2025

I am unsure about the better fix here. Why not eliminate the global variable if that fixes the problem? Then it will make the other PR smaller.

@StanFromIreland
Copy link
Member Author

@merwok I updated the PR with that if that is what you prefer, it is not too bad, the diff is pretty low.

@StanFromIreland StanFromIreland requested a review from merwok May 2, 2025 20:15
@serhiy-storchaka
Copy link
Member

Sharing MESSAGES between files is a (mis-)feature. See #10875 which solves this problem more thoroughly.

@StanFromIreland
Copy link
Member Author

Do you mind splitting it from the larger pr, it would simplify it as Eric mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants