Skip to content

gh-133448: Fix test_file in test_urllib2 on Windows with a longer repo path #133449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −15
Open

gh-133448: Fix test_file in test_urllib2 on Windows with a longer repo path #133449

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4fd462
Fix test_file in test_urllib2 on Windows with a longer repo path
aisk May 5, 2025
6040036
Merge remote-tracking branch 'upstream/main' into fix-urllib2-test
aisk Jun 15, 2025
83851a2
Merge branch 'main' into fix-urllib2-test
serhiy-storchaka Sep 3, 2025
985fee0
Update by review
aisk Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Lib/test/test_urllib2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,14 +850,16 @@ def test_file(self):
self.assertEqual(headers["Last-modified"], modified)
self.assertEqual(respurl, canonurl)

_, cwd = os.path.splitdrive(os.getcwd())
cwd = cwd.replace("\\", "/")
for url in [
parsed._replace(netloc='localhost:80').geturl(),
"file:///file_does_not_exist.txt",
"file://not-a-local-host.com//dir/file.txt",
"file://%s:80%s/%s" % (socket.gethostbyname('localhost'),
os.getcwd(), TESTFN),
cwd, TESTFN),
"file://somerandomhost.ontheinternet.com%s/%s" %
(os.getcwd(), TESTFN),
(cwd, TESTFN),
]:
try:
f = open(TESTFN, "wb")
Expand Down
Loading