gh-132467: Add test case to check whether GenericAlias instance is not class, update docstring of typing._GenericAlias
#133504
Conversation
…d to be class, update docstring of typing._GenericAlias
AbduazizZiyodov
requested review from
AlexWaygood and
JelleZijlstra
as code owners
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Co-authored-by: Jelle Zijlstra <[email protected]>
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Hi @JelleZijlstra, I(we)'ve addressed requested changes, just checking in if there is anything needed from my side? Thanks. |
2 participants
Description
As discussed in the issue, we can't change behaviour of
inspect.isclassfor GenericAlias instances, so that we need to document that they are not considered to be a class.Summary
typing._GenericAlias. Added one note, changed format of docstring a bit* edit: I should not have updated typing docs, doc was for typing spec only, not about runtime behaviour. So I updated stdtypes docs.
inspect.isclassreturns False forGenericAliasinstances #132467