Skip to content

gh-133562: disable security descriptor handling on unsupported WinAPI partitions #133563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 14, 2025
Merged

gh-133562: disable security descriptor handling on unsupported WinAPI partitions #133563

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
078f691
disable security descriptor handling on unsupported WinAPI partitions
maxbachmann May 7, 2025
243f377
📜🤖 Added by blurb_it.
blurb-it[bot] May 7, 2025
24aeedf
fix linter error
maxbachmann May 7, 2025
4c98d03
fix guard
maxbachmann May 7, 2025
e2ee3d0
Update Modules/posixmodule.c
maxbachmann May 7, 2025
8c37fa1
Update Misc/NEWS.d/next/Library/2025-05-07-09-02-19.gh-issue-133562.l…
maxbachmann May 7, 2025
2575d66
move news entry
maxbachmann May 7, 2025
2f31305
Merge branch 'main' into patch-3
zooba May 9, 2025
c71e24f
Merge branch 'main' into patch-3
zooba May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-05-07-09-02-19.gh-issue-133562.lqqNW1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Disable handling of security descriptors by :func:`os.mkdir` with mode ``0o700`` on WinAPI partitions that do not support it.
2 changes: 2 additions & 0 deletions Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5726,6 +5726,7 @@ os_mkdir_impl(PyObject *module, path_t *path, int mode, int dir_fd)

#ifdef MS_WINDOWS
Py_BEGIN_ALLOW_THREADS
#if defined(MS_WINDOWS_DESKTOP) || defined(MS_WINDOWS_SYSTEM)
Copy link
Contributor

@sergey-miryanov sergey-miryanov May 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should explicitly use MS_WINDOWS_GAMES or comment that it is for XBox build?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided last time around to use inclusive filters rather than exclusion ones - we know the platforms where the API is available, and it won't be removed from those.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explanation!

if (mode == 0700 /* 0o700 */) {
ULONG sdSize;
pSecAttr = &secAttr;
Expand All @@ -5741,6 +5742,7 @@ os_mkdir_impl(PyObject *module, path_t *path, int mode, int dir_fd)
error = GetLastError();
}
}
#endif
if (!error) {
result = CreateDirectoryW(path->wide, pSecAttr);
if (secAttr.lpSecurityDescriptor &&
Expand Down
Loading