Skip to content

gh-133677: Skip test in test_httpservers if not utf-8 #133706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

gh-133677: Skip test in test_httpservers if not utf-8 #133706

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
302127f
Skip test if not utf-8
StanFromIreland May 8, 2025
e45a58d
more import
StanFromIreland May 8, 2025
d1ab24c
Fixup
StanFromIreland May 9, 2025
6f951b7
fixup fixup
StanFromIreland May 9, 2025
f1a67dc
Revert comment change
StanFromIreland May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/test/test_httpservers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
SimpleHTTPRequestHandler, CGIHTTPRequestHandler
from http import server, HTTPStatus

import locale
import os
import socket
import sys
Expand Down Expand Up @@ -551,11 +552,12 @@ def test_undecodable_filename(self):
self.check_status_and_reason(response, HTTPStatus.OK,
data=os_helper.TESTFN_UNDECODABLE)

@unittest.skipIf(locale.getpreferredencoding().lower() != 'utf-8', 'test requires utf-8')
def test_undecodable_parameter(self):
# sanity check using a valid parameter
response = self.request(self.base_url + '/?x=123').read()
self.assertRegex(response, rf'listing for {self.base_url}/\?x=123'.encode('latin1'))
# now the bogus encoding
# now the bogus (utf-8) encoding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should be reverted as well.

response = self.request(self.base_url + '/?x=%bb').read()
self.assertRegex(response, rf'listing for {self.base_url}/\?x=\xef\xbf\xbd'.encode('latin1'))

Expand Down
Loading