gh-131421: Fix ASDL kw_defaults being expr* instead of expr?* (+ fix docs ASDL highlighting)
#133773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kw_defaults` According to the docs: > (https://docs.python.org/3.15/library/ast.html#ast.arguments) > kw_defaults is a list of default values for keyword-only arguments. If one is None, the corresponding argument is required. However, ASDL's description of `kw_defaults` is that it simply a `expr*`, and not a `expr?*` as stated by the docs.
Demonstrandum
requested review from
AA-Turner,
hugovk,
lysnikolaou and
pablogsal
as code owners
|
We'll just backport this to 3.14 (it'd be really weird to have the first part in 3.14 but not this one) |
|
any way I can help getting this done? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs:
However, ASDL's description of
kw_defaultsis that it simply aexpr*, and not aexpr?*as stated by the docs.This continues the same correction for
exprDictin the ASDL in PR #131419.I also corrected the syntax highlighting regex to support the chained qualifiers syntax introduced to the ASDL.
Python.asdltype forkeysinDictliterals #131421📚 Documentation preview 📚: https://cpython-previews--133773.org.readthedocs.build/