Skip to content

gh-132983: Make zstd types immutable #133784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2025
Merged

gh-132983: Make zstd types immutable #133784

merged 3 commits into from
May 10, 2025

Conversation

@AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented May 9, 2025 •
edited by bedevere-app bot
Loading

I haven't added tests as the other modules don't seem to have any for immutable types, but happy to do so if wanted.

A

@bedevere-app bedevere-app bot mentioned this pull request May 9, 2025
Closed
13 tasks
@AA-Turner AA-Turner mentioned this pull request May 9, 2025
Merged
picnixz
picnixz reviewed May 9, 2025
View reviewed changes
@AA-Turner AA-Turner added the needs backport to 3.14 bugs and security fixes label May 9, 2025
@AA-Turner AA-Turner enabled auto-merge (squash) May 10, 2025 22:12
@AA-Turner AA-Turner merged commit 1a87b6e into python:main May 10, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2025
@AA-Turner @miss-islington
pythongh-132983: Make zstd types immutable (pythonGH-133784)
4146ed7 
(cherry picked from commit 1a87b6e)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2025

GH-133857 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 10, 2025
@AA-Turner AA-Turner deleted the zstd-immutable-types branch May 10, 2025 22:56
AA-Turner added a commit that referenced this pull request May 10, 2025
@miss-islington @AA-Turner
[3.14] gh-132983: Make zstd types immutable (GH-133784) (#133857)
1e8a534 
gh-132983: Make zstd types immutable (GH-133784)
(cherry picked from commit 1a87b6e)

Co-authored-by: Adam Turner <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@AA-Turner @Pranjal095
pythongh-132983: Make zstd types immutable (python#133784)
5acf5e4
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@AA-Turner @taegyunkim
pythongh-132983: Make zstd types immutable (python#133784)
94d7f43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@picnixz picnixz picnixz left review comments

@emmatyping emmatyping emmatyping approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AA-Turner @vstinner @serhiy-storchaka @emmatyping @picnixz