gh-81313: Add the intmath module (PEP-791) #133909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
requested review from
a team,
corona10 and
erlend-aasland
as code owners
|
This is a further development of #13741. |
|
A PEP is being written for this module: skirpichev/peps#8 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
skirpichev
reviewed
May 12, 2025
Comment on lines
12
to
13
| These functions accept integers and objects that implement the | ||
| :meth:`~object.__index__` method which is used to convert the object to an integer |
There was a problem hiding this comment.
In the same way we could simplify now description of argument processing in the math module. Except for a special snowflake "log" - all use PyFloat_AsDouble(). (Well, few functions also try special dunder methods.)
Though, probably it's for following prs.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
skirpichev
changed the title
picnixz
changed the title
skirpichev
reviewed
Jun 1, 2025
Comment on lines
+14
to
+15
| number. They cannot be used with floating-point numbers or complex | ||
| numbers. |
There was a problem hiding this comment.
Last sentence looks redundant, though maybe it worth to be here.
Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Sergey B Kirpichev <[email protected]>
skirpichev
approved these changes
Jun 1, 2025
| expression (1 + x)**n. | ||
| Raises ValueError if either of the arguments are negative. | ||
picnixz
reviewed
Jun 1, 2025
| Return factorial of the nonnegative integer *n*. | ||
|
|
||
|
|
||
| .. function:: gcd(a, b) |
skirpichev
reviewed
Jun 1, 2025
| Return factorial of the nonnegative integer *n*. | ||
|
|
||
|
|
||
| .. function:: gcd(a, b) |
There was a problem hiding this comment.
Suggested change
| .. function:: gcd(a, b) | |
| .. function:: gcd(*integers) |
picnixz
reviewed
Jun 1, 2025
skirpichev
reviewed
Jun 1, 2025
Comment on lines
+89
to
+90
| This module provides access to the mathematical functions for integer arguments. | ||
| (Contributed by Serhiy Storchaka in :gh:`81313`.) |
There was a problem hiding this comment.
Suggested change
| This module provides access to the mathematical functions for integer arguments. | |
| (Contributed by Serhiy Storchaka in :gh:`81313`.) | |
| This module provides access to the mathematical functions for integer | |
| arguments (:pep:`791`). | |
| (Contributed by Serhiy Storchaka in :gh:`81313`.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--133909.org.readthedocs.build/