Skip to content

Conversation

abhigyan631
Copy link

@abhigyan631 abhigyan631 commented May 12, 2025

@python-cla-bot
Copy link

python-cla-bot bot commented May 12, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented May 12, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@skirpichev skirpichev added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 12, 2025
@skirpichev
Copy link
Contributor

@abhigyan631, you shouldn't modify auto-generated files by hand. Instead, make changes in Module/mathmodule.c and run make clinic. Please take look on https://devguide.python.org/.

BTW, someone already works on this issue: #133907

@abhigyan631
Copy link
Author

@abhigyan631, you shouldn't modify auto-generated files by hand. Instead, make changes in Module/mathmodule.c and run make clinic. Please take look on https://devguide.python.org/.

BTW, someone already works on this issue: #133907

Ok thank you for the reference provided. Will make sure from next time.

@skirpichev
Copy link
Contributor

Lets close this in favor of #133907

@skirpichev skirpichev closed this May 12, 2025
@AA-Turner AA-Turner removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants