[3.14] gh-132641: fix race in lru_cache under free-threading (GH-133787)
#133979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GH-133787) Fix race in `lru_cache` by acquiring critical section on the cache object itself and call the lock held variant of dict functions to modify the underlying dict. (cherry picked from commit 9ad0c7b) Co-authored-by: Peter Hawkins <[email protected]>
miss-islington
requested review from
markshannon,
methane and
rhettinger
as code owners
This was referenced May 13, 2025
kumaraditya303
approved these changes
May 13, 2025
rhettinger
requested review from
serhiy-storchaka
and removed request for
rhettinger
serhiy-storchaka
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race in
lru_cacheby acquiring critical section on the cache object itself and call the lock held variant of dict functions to modify the underlying dict.(cherry picked from commit 9ad0c7b)
Co-authored-by: Peter Hawkins [email protected]