Skip to content

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented May 15, 2025

@kumaraditya303 kumaraditya303 marked this pull request as ready for review May 19, 2025 14:11
@kumaraditya303 kumaraditya303 requested a review from colesbury May 20, 2025 15:43
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a scaling test associated with this to ftscalingbench.py

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented May 23, 2025

I have added method_caller benchmark to ftscalingbench.py

Result on my machine before and after this PR:

Before:./python.bat Tools/ftscalingbench/ftscalingbench.py --threads=8 method_caller
Running Release|x64 interpreter...
Running benchmarks with 8 threads
method_caller                1.8x faster

After:./python.bat Tools/ftscalingbench/ftscalingbench.py --threads=8 method_caller
Running Release|x64 interpreter...
Running benchmarks with 8 threads
method_caller                4.9x faster

@kumaraditya303 kumaraditya303 requested a review from colesbury May 26, 2025 17:04
@kumaraditya303 kumaraditya303 merged commit a380d57 into python:main May 27, 2025
42 checks passed
@kumaraditya303 kumaraditya303 deleted the stackref-call branch May 27, 2025 16:58
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
Adds `_PyObject_GetMethodStackRef` which uses stackrefs and takes advantage of deferred reference counting in free-threading while calling method objects in vectorcall.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Adds `_PyObject_GetMethodStackRef` which uses stackrefs and takes advantage of deferred reference counting in free-threading while calling method objects in vectorcall.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants