Skip to content

Conversation

@maxbachmann
Copy link
Contributor

@zooba as discussed in #134042 this dynamically loads GetNamedPipeHandleStateW from Kernel32.dll

@zooba
Copy link
Member

zooba commented May 15, 2025

This is fine, but be aware that if/when the Windows headers start including the API, it'll cause a compiler error, at which point we'll need some way to detect either the headers version (if such a thing exists?) to fix it - I don't think we can assume that all possible users will be able to update their headers immediately.

I thought about suggesting moving the #if inside the function, renaming it, and updating the call, but we can do that later if needed. A compiler error here might be the only way we discover if it gets added.

@zooba zooba merged commit 20095fb into python:main May 15, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants