Skip to content

Conversation

@johnzhou721
Copy link
Contributor

@johnzhou721 johnzhou721 commented May 16, 2025

A medium-sized batch of random typo fixes. Ran codespell and caught a few obvious typos -- with a lot more false positive garbage. Things that I'm not sure with and has multiple occurrences, I did not fix.

Please skip news and skip issue since this is trivial.

Thanks,
John

@johnzhou721 johnzhou721 requested a review from a team as a code owner May 16, 2025 02:11
@johnzhou721
Copy link
Contributor Author

I apologize for the large amount of people that this notified; also, 3 hours late, but I hope that any PyCon attendents that happen to see this had a good opening reception.

@skirpichev
Copy link
Contributor

@johnzhou721, please avoid pr with stylistic fixes. We welcome fixes for typos and grammar errors, but when they really affect users (i.e. in docstrings, documentation, error messages).

@skirpichev skirpichev closed this May 16, 2025
@johnzhou721 johnzhou721 deleted the typobatch1 branch May 16, 2025 02:52
@johnzhou721
Copy link
Contributor Author

johnzhou721 commented May 16, 2025 via email

@johnzhou721
Copy link
Contributor Author

@skirpichev I have a question -- why is #106247 merged then? Is it because they have commit bit so it takes less work to get merged?

I'm just curious about policy on such things. Thanks

@skirpichev
Copy link
Contributor

I'm just curious about policy on such things.

https://devguide.python.org/getting-started/pull-request-lifecycle/#making-good-prs

@johnzhou721
Copy link
Contributor Author

Thanks. Thought that the sysconfig thing would be a docstring but turned out it was a private function (I was like if they have 2 docstrings and more typos than me 1 docstring should count for me but just realized it's a private function beginning with _... this is what happens when someone's not good at python fundamentals...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants