gh-134070: Fix mi_clz32/mi_ctz32 to prevent out-of-bounds read (GH-134149) #134157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not open multiple PRs. Close either of the two. |
This comment was marked as resolved.
This comment was marked as resolved.
|
I'm going to close this one: see #134149 (comment). |
|
I'm sorry for this,fresh contributor still learning! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an out-of-bounds read in the generic implementation of
mi_clz32andmi_ctz32in the integrated mimalloc allocator.This issue could occur on platforms with 64-bit unsigned long values.
The fix follows the approach from the upstream patch in microsoft/mimalloc:
microsoft/mimalloc@ed3184752c80f73e362