Skip to content

gh-130478: Fixed HACL compilation failure on macOS Silicon #134188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 1, 2025
Merged

gh-130478: Fixed HACL compilation failure on macOS Silicon #134188

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
be5d371
Fixed: HACL compilation failure on macOS Silicon
naizhao May 18, 2025
2f7b2db
Fix: Update configure checks for HACL SIMD (addressing review feedback)
naizhao May 18, 2025
494672b
Merge branch 'python:main' into main
naizhao May 19, 2025
c11f348
Fix: Address feedback on HACL* universal2 configure checks
naizhao May 19, 2025
b05d183
Update configure.ac
naizhao May 19, 2025
e89919d
update configure
naizhao May 19, 2025
5054d4b
Merge branch 'python:main' into main
naizhao Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7936,7 +7936,7 @@ then
# available on x86_64. However, performance of the HACL SIMD128 implementation
# isn't great, so it's disabled on ARM64.
AC_MSG_CHECKING([for HACL* SIMD128 implementation])
if test "$UNIVERSAL_ARCHS" == "universal2"; then
if test "$UNIVERSAL_ARCHS" = "universal2" -o \( "$build_cpu" = "aarch64" -a "$build_vendor" = "apple" \); then
[LIBHACL_BLAKE2_SIMD128_OBJS="Modules/_hacl/Hacl_Hash_Blake2s_Simd128_universal2.o"]
AC_MSG_RESULT([universal2])
else
Expand Down Expand Up @@ -7968,7 +7968,7 @@ then
# implementation requires symbols that aren't available on ARM64. Use a
# wrapped implementation if we're building for universal2.
AC_MSG_CHECKING([for HACL* SIMD256 implementation])
if test "$UNIVERSAL_ARCHS" == "universal2"; then
if test "$UNIVERSAL_ARCHS" = "universal2" -o \( "$build_cpu" = "aarch64" -a "$build_vendor" = "apple" \); then
[LIBHACL_BLAKE2_SIMD256_OBJS="Modules/_hacl/Hacl_Hash_Blake2b_Simd256_universal2.o"]
AC_MSG_RESULT([universal2])
else
Expand Down
Loading