Skip to content

gh-131798: Split CALL_LIST_APPEND into serveral uops #134240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 19, 2025
Merged

gh-131798: Split CALL_LIST_APPEND into serveral uops #134240

merged 6 commits into from
May 19, 2025

Conversation

diegorusso
Copy link
Contributor

@diegorusso diegorusso commented May 19, 2025 •
edited by bedevere-app bot
Loading

@diegorusso diegorusso requested a review from brandtbucher May 19, 2025 15:11
@diegorusso diegorusso changed the title gh-133180: Optimize _CALL_LIST_APPEND gh-131798: Optimize _CALL_LIST_APPEND May 19, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 19, 2025
Open
Fidget-Spinner
Fidget-Spinner reviewed May 19, 2025
View reviewed changes
@diegorusso diegorusso changed the title gh-131798: Optimize _CALL_LIST_APPEND gh-131798: Split CALL_LIST_APPEND into serveral uops May 19, 2025
brandtbucher
brandtbucher approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing:

@diegorusso
Copy link
Contributor Author

The failures on macOS will be fixed by: #134224
The Windows error is being worked by @brandtbucher and pushed soon.

@diegorusso diegorusso merged commit 42d03f3 into python:main May 19, 2025
50 of 60 checks passed
@diegorusso diegorusso deleted the call_list_append branch May 19, 2025 19:49
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@diegorusso @Pranjal095
pythonGH-131798: Split CALL_LIST_APPEND into several uops (pythonGH-1…
1699e48 
…34240)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@diegorusso @taegyunkim
pythonGH-131798: Split CALL_LIST_APPEND into several uops (pythonGH-1…
7e8cdc1 
…34240)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments

@brandtbucher brandtbucher brandtbucher approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@diegorusso @Fidget-Spinner @brandtbucher