Skip to content

gh-88994: Change datetime.now to half-even rounding for consistency with datetime.fromtimestamp. #134258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 19, 2025
Merged

gh-88994: Change datetime.now to half-even rounding for consistency with datetime.fromtimestamp. #134258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
494b04f
Change `datetime.now` to half-even rounding for consistency with `dat…
jhohm May 19, 2025
6b53c73
📜🤖 Added by blurb_it.
blurb-it[bot] May 19, 2025
654fcc4
Fix func references in NEWS blurb to qualify `datetime` module contents.
jhohm May 19, 2025
84c6755
Add jhohm to ACKS and note as author of patch
jhohm May 19, 2025
15a97fd
Conform to PEP 7 on changed line.
jhohm May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/ACKS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,7 @@ Albert Hofkamp
Chris Hogan
Tomas Hoger
Jonathan Hogg
John Keith Hohm
Vladyslav Hoi
Kamilla Holanda
Steve Holden
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2025-05-19-18-12-42.gh-issue-88994.7avvVu.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Change :func:`datetime.datetime.now` to half-even rounding for
consistency with :func:`datetime.datetime.fromtimestamp`. Patch by
John Keith Hohm.
3 changes: 2 additions & 1 deletion Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5539,8 +5539,9 @@ datetime_best_possible(PyObject *cls, TM_FUNC f, PyObject *tzinfo)
time_t secs;
int us;

if (_PyTime_AsTimevalTime_t(ts, &secs, &us, _PyTime_ROUND_FLOOR) < 0)
if (_PyTime_AsTimevalTime_t(ts, &secs, &us, _PyTime_ROUND_HALF_EVEN) < 0) {
return NULL;
}
assert(0 <= us && us <= 999999);

return datetime_from_timet_and_us(cls, f, secs, us, tzinfo);
Expand Down
Loading