gh-134215: PyREPL: Do not show underscored modules by default during autocompletion #134267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add _should_add_module_name method to the ModuleCompleter module * Add new tests to check autocomplete behaviour on private method
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
…to pyrepl_underscored_fix
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@tomasr8 ready for your review! |
Co-authored-by: Stan Ulbrych <[email protected]>
…to pyrepl_underscored_fix
Co-authored-by: Stan Ulbrych <[email protected]>
tomasr8
reviewed
May 19, 2025
Misc/NEWS.d/next/Tools-Demos/2025-05-19-14-57-46.gh-issue-134215.sbdDK6.rst
Outdated
Show resolved
Hide resolved
…15.sbdDK6.rst Co-authored-by: Tomas R. <[email protected]>
…to pyrepl_underscored_fix
tomasr8
reviewed
May 20, 2025
…to pyrepl_underscored_fix
tomasr8
approved these changes
May 20, 2025
tomasr8
changed the title
ambv
approved these changes
May 20, 2025
tomasr8
reviewed
May 20, 2025
Co-authored-by: Tomas R. <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2025
…uring autocompletion (pythongh-134267) (cherry picked from commit a3a3cf6) Co-authored-by: Kevin Hernández <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Tomas R. <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>
|
GH-134388 is a backport of this pull request to the 3.14 branch. |
|
Congrats @kevteg !! |
ambv
added a commit
that referenced
this pull request
May 20, 2025
…during autocompletion (gh-134267) (gh-134388) (cherry picked from commit a3a3cf6) Co-authored-by: Kevin Hernández <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Tomas R. <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
May 26, 2025
…uring autocompletion (pythongh-134267) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Tomas R. <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…uring autocompletion (pythongh-134267) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Tomas R. <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…uring autocompletion (pythongh-134267) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Tomas R. <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_is_suggestion_matchmethod to the ModuleCompleter module