Skip to content

Conversation

@bitdancer
Copy link
Member

@bitdancer bitdancer commented May 19, 2025

In this case, the higher level syntactic unit fit on the remainder of the line in un-encoded format, so the encoding check never happened. To fix this, we look inside the current unit to see if has anything that was originally encoded.

I'm not really happy with the method name 'has_token_type', but I haven't thought of anything I like better. Ideas welcome.

In this case, the higher level syntactic unit fit on the remainder of
the line in un-encoded format, so the encoding check never happened.  To
fix this, we look inside the current unit to see if has anything that
was originally encoded.
@bitdancer
Copy link
Member Author

@medmunds Do you feel like reviewing this? :)

@medmunds
Copy link
Contributor

I'm not really happy with the method name 'has_token_type', but I haven't thought of anything I like better. Ideas welcome.

contains_token_type? (Though I'm not convinced that's any better; has_token_type makes sense to me too.)

Copy link
Contributor

@medmunds medmunds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix LGTM. But I found another corner case while looking at it. Here's the failing test:

--- a/Lib/test/test_email/test__header_value_parser.py	(revision ebde4e897750963b82bcae785949ac11b3877640)
+++ b/Lib/test/test_email/test__header_value_parser.py	(date 1748289921461)
@@ -3101,6 +3101,8 @@
              '=?utf-8?q?a=2C?=\n'
              ' 123456789012345678901234567890123456\n'
              ' <[email protected]>\n'),
+            ('[email protected] (, but definitely not also sent to [email protected])',
+             '[email protected] (, but definitely not\n also sent to [email protected])\n'),
         ]
         for (to, folded) in cases:
             with self.subTest(to=to):

(This case belongs in a new test covering comment folding, but you'll get the point. Guessing I should open a new issue—it's more like the earlier quoted-string problem. I bring it up here in case it might help you spot other xtext variations needing attention.)

(Also, is this on Seth's radar yet?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants