Skip to content

Conversation

@biniona
Copy link
Contributor

@biniona biniona commented May 19, 2025

Expands Documentation of Base-85 encodings. Explains history of de-facto standard and how to pick between the two Base-85 encoding functions in the base-64 module.

@python-cla-bot
Copy link

python-cla-bot bot commented May 19, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@biniona biniona marked this pull request as ready for review May 19, 2025 22:14
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor changes to clarify the text.

@CAM-Gerlach CAM-Gerlach changed the title gh-134201: Expand Base-85 Documentation gh-134201: Expand Base85 Documentation May 19, 2025
@CAM-Gerlach CAM-Gerlach self-requested a review May 19, 2025 23:55
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @biniona !

@CAM-Gerlach CAM-Gerlach merged commit 66aaad6 into python:main May 19, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs May 19, 2025
@CAM-Gerlach CAM-Gerlach added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 19, 2025
@miss-islington-app
Copy link

Thanks @biniona for the PR, and @CAM-Gerlach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @biniona for the PR, and @CAM-Gerlach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2025
pythonGH-134288)

Explain history of de-facto standard and how to pick between the two Base-85 encoding functions in the base-64 module.

---------
(cherry picked from commit 66aaad6)

Co-authored-by: Alek Binion <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2025
pythonGH-134288)

Explain history of de-facto standard and how to pick between the two Base-85 encoding functions in the base-64 module.

---------
(cherry picked from commit 66aaad6)

Co-authored-by: Alek Binion <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 19, 2025

GH-134297 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 19, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 19, 2025

GH-134298 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 19, 2025
CAM-Gerlach added a commit that referenced this pull request May 20, 2025
…cs (GH-134288) (#134298)

gh-134201: Expand explanation of Base85 encodings in base64 docs (GH-134288)

Explain history of de-facto standard and how to pick between the two Base-85 encoding functions in the base-64 module.

---------
(cherry picked from commit 66aaad6)

Co-authored-by: Alek Binion <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
CAM-Gerlach added a commit that referenced this pull request May 20, 2025
…cs (GH-134288) (#134297)

gh-134201: Expand explanation of Base85 encodings in base64 docs (GH-134288)

Explain history of de-facto standard and how to pick between the two Base-85 encoding functions in the base-64 module.

---------
(cherry picked from commit 66aaad6)

Co-authored-by: Alek Binion <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
@cmaloney
Copy link
Contributor

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
python#134288)

Explain history of de-facto standard and how to pick between the two Base-85 encoding functions in the base-64 module.

---------

Co-authored-by: C.A.M. Gerlach <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
python#134288)

Explain history of de-facto standard and how to pick between the two Base-85 encoding functions in the base-64 module.

---------

Co-authored-by: C.A.M. Gerlach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants