Skip to content

gh-118234: Avoid socket failure with missing SYSTEMROOT env var on Windows #134363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

gh-118234: Avoid socket failure with missing SYSTEMROOT env var on Windows #134363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d353545
Avoid socket failure with missing SYSTEMROOT env var on Windows
jhohm May 20, 2025
bf89233
blurb
jhohm May 20, 2025
674ec21
Fix indentation to conform to PEP 7.
jhohm May 20, 2025
76c2645
Merge branch 'python:main' into gh-118234
jhohm May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Windows/2025-05-20-12-35-33.gh-issue-118234.HjbkIh.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Avoid socket failure with missing SYSTEMROOT env var on Windows. Patch by
John Keith Hohm.
19 changes: 19 additions & 0 deletions Modules/socketmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,21 @@ remove_unusable_flags(PyObject *m)
return 0;
}

/* issue #118234, avoid WinError 10106 with empty environment */
static void ensure_system_root() {
LPCWSTR name = L"SystemRoot";
DWORD size = GetEnvironmentVariableW(name, NULL, 0);
if (size) {
return;
}
wchar_t root[4096];
UINT len = GetWindowsDirectoryW(root, 4096);
if (len == 0 || len >= 4096) {
return;
}
SetEnvironmentVariableW(name, root);
}

#endif

#include <stddef.h>
Expand Down Expand Up @@ -5618,6 +5633,10 @@ sock_initobj_impl(PySocketSockObject *self, int family, int type, int proto,
SOCKET_T fd = INVALID_SOCKET;
socket_state *state = find_module_state_by_def(Py_TYPE(self));

#ifdef MS_WINDOWS
ensure_system_root();
#endif

#ifndef MS_WINDOWS
#ifdef SOCK_CLOEXEC
int *atomic_flag_works = &sock_cloexec_works;
Expand Down
Loading