Skip to content

gh-128066: Properly handle history file writes for RO fs on PyREPL #134380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 20, 2025
Merged

gh-128066: Properly handle history file writes for RO fs on PyREPL #134380

merged 7 commits into from
May 20, 2025

Conversation

@feoh
Copy link
Contributor

@feoh feoh commented May 20, 2025 •
edited
Loading

@python-cla-bot
Copy link

python-cla-bot bot commented May 20, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request May 20, 2025
Closed
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ambv ambv changed the title gh-128066: Properly handle history file writes for RO fs on PyRepl gh-128066: Properly handle history file writes for RO fs on PyREPL May 20, 2025
@ambv ambv mentioned this pull request May 20, 2025
Closed
@ambv ambv merged commit c91ad5d into python:main May 20, 2025
47 checks passed
@ambv ambv added the needs backport to 3.14 bugs and security fixes label May 20, 2025
@miss-islington-app
Copy link

Thanks @feoh for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@feoh @ambv @miss-islington
pythongh-128066: Properly handle history file writes for RO fs on PyR…
4c7726f 
…EPL (pythongh-134380)

(cherry picked from commit c91ad5d)

Co-authored-by: Chris Patti <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

GH-134385 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
@ambv ambv added the needs backport to 3.13 bugs and security fixes label May 20, 2025
@miss-islington-app
Copy link

Thanks @feoh for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @feoh and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c91ad5da9d92eac4718e4da8d53689c3cc24535e 3.13

ambv added a commit to ambv/cpython that referenced this pull request May 20, 2025
@feoh @ambv
[3.13] pythongh-128066: Properly handle history file writes for RO fs…
d6a3cdc 
… on PyREPL (pythongh-134380)

(cherry picked from commit c91ad5d)

Co-authored-by: Chris Patti <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

GH-134386 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 20, 2025
ambv added a commit that referenced this pull request May 20, 2025
@miss-islington @feoh @ambv
[3.14] gh-128066: Properly handle history file writes for RO fs on Py…
379805d 
…REPL (gh-134380) (gh-134385)

(cherry picked from commit c91ad5d)

Co-authored-by: Chris Patti <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request May 20, 2025
@ambv @feoh
[3.13] gh-128066: Properly handle history file writes for RO fs on Py…
b41e7b1 
…REPL (gh-134380) (gh-134386)

(cherry picked from commit c91ad5d)

Co-authored-by: Chris Patti <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@feoh @ambv @lkollar
pythongh-128066: Properly handle history file writes for RO fs on PyR…
d251f8d 
…EPL (pythongh-134380)

Co-authored-by: Łukasz Langa <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@feoh @ambv @Pranjal095
pythongh-128066: Properly handle history file writes for RO fs on PyR…
aa0f8bf 
…EPL (pythongh-134380)

Co-authored-by: Łukasz Langa <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@feoh @ambv @taegyunkim
pythongh-128066: Properly handle history file writes for RO fs on PyR…
3fbcbbe 
…EPL (pythongh-134380)

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

@ambv ambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@feoh @ambv