-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-134471: Fix asyncio.timeout(0) swallowing an unrelated prior cancellation.
#134472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
okhaliavka
wants to merge
1
commit into
python:main
Choose a base branch
from
okhaliavka:fix-timeout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
| import time | ||
|
|
||
| import asyncio | ||
| from asyncio import CancelledError | ||
|
|
||
| from test.test_asyncio.utils import await_without_task | ||
|
|
||
|
|
@@ -298,6 +299,18 @@ async def test_nested_timeout_in_finally(self): | |
| self.assertIs(e2.__context__, e22) | ||
|
|
||
| async def test_timeout_after_cancellation(self): | ||
| asyncio.current_task().cancel() | ||
| with self.assertRaises(asyncio.CancelledError): | ||
| async with asyncio.timeout(0.1): | ||
| await asyncio.sleep(1) | ||
|
|
||
| async def test_timeout_immediately_after_cancellation(self): | ||
| asyncio.current_task().cancel() | ||
| with self.assertRaises(asyncio.CancelledError): | ||
| async with asyncio.timeout(0.0): | ||
| await asyncio.sleep(1) | ||
|
Comment on lines
+307
to
+311
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this added test fails on all python versions and the proposed fix makes it pass without breaking any other tests |
||
|
|
||
| async def test_timeout_while_handling_cancellation(self): | ||
| try: | ||
| asyncio.current_task().cancel() | ||
| await asyncio.sleep(1) # work which will be cancelled | ||
|
|
@@ -308,7 +321,7 @@ async def test_timeout_after_cancellation(self): | |
| async with asyncio.timeout(0.0): | ||
| await asyncio.sleep(1) # some cleanup | ||
|
|
||
| async def test_cancel_in_timeout_after_cancellation(self): | ||
| async def test_cancel_in_timeout_while_handling_cancellation(self): | ||
| try: | ||
| asyncio.current_task().cancel() | ||
| await asyncio.sleep(1) # work which will be cancelled | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i feel uneasy messing around with this internal
_must_cancelbut i didn't find any other way to fix this. changing the cancellation counting logic breakstimeoutusage while handlingCancelledError, where it should indeed disregard the previous cancellation (the one it's handling). I couldn't get both cases to work by only relying on counting (cancelling).so i needed something more "surgical" to be able to tell whether we're currently handling
CancelledErroror we're just in an already cancelled task that didn't get thrown aCancelledErroryet