[3.14] gh-127960 Fix the REPL to set the correct namespace by setting the correct __main__ module (gh-134275)
#134473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the correct `__main__` module (pythongh-134275) The `__main__` module imported in the `_pyrepl` module points to the `_pyrepl` module itself when the interpreter was launched without `-m` option and didn't execute a module, while it's an unexpected behavior that `__main__` can be `_pyrepl` and relative imports such as `from . import *` works based on the `_pyrepl` module. (cherry picked from commit b1b8962) Co-authored-by: Yuichiro Tachibana (Tsuchiya) <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>
miss-islington
requested review from
ambv,
ericsnowcurrently,
lysnikolaou and
pablogsal
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__main__module imported in the_pyreplmodule points to the_pyreplmodule itself when the interpreter was launched without-moption and didn't execute a module,while it's an unexpected behavior that
__main__can be_pyrepland relative imports such asfrom . import *works based on the_pyreplmodule.(cherry picked from commit b1b8962)
Co-authored-by: Yuichiro Tachibana (Tsuchiya) [email protected]
Co-authored-by: Łukasz Langa [email protected]
from . import *within the REPL will import the_pyreplpackage, But executing with the-cargument will result in an error. #127960