- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.3k
gh-134567: Exposes log format to users in unittest.TestCase.assertLogs #134570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            12 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      f8ff127
              
                Exposes log format to users in unittest.TestCase.assertLogs
              
              
                garry-cairns 59e8f3f
              
                📜🤖 Added by blurb_it.
              
              
                blurb-it[bot] 821f828
              
                Merge branch 'main' into fix-issue-134567
              
              
                garry-cairns d96dca3
              
                Merge branch 'python:main' into fix-issue-134567
              
              
                garry-cairns 6009858
              
                Adds docs and corrects docstring
              
              
                garry-cairns 7881c64
              
                Updates unittest docs
              
              
                garry-cairns ff3e9af
              
                Merge branch 'python:main' into fix-issue-134567
              
              
                garry-cairns ec353d2
              
                Resolves review comments from pr 134570
              
              
                garry-cairns 766d6a2
              
                Merge branch 'python:main' into fix-issue-134567
              
              
                garry-cairns 7ee8aba
              
                Addresses review comments on gh-134567
              
              
                garry-cairns 10aa529
              
                Merge branch 'python:main' into fix-issue-134567
              
              
                garry-cairns ca72d91
              
                Addresses review comments on gh-134570
              
              
                garry-cairns File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            2 changes: 2 additions & 0 deletions
          
          2 
        
  Misc/NEWS.d/next/Tests/2025-05-23-09-19-52.gh-issue-134567.hwEIMb.rst
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Expose log formatter to users in TestCase.assertLogs. | ||
| :func:`unittest.TestCase.assertLogs` will now optionally accept a formatter that will be used to format the strings in output if provided. | 
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garry-cairns This is under the "Removed" section:
https://docs.python.org/3.15/whatsnew/3.15.html#removed
Please could you move it to the "Improved modules" section above?
https://docs.python.org/3.15/whatsnew/3.15.html#improved-modules
(We could also remove the first sentence "Lets users specify formatter in TestCase.assertLogs", as the next sentence essentially repeats it.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the noise on this. I've created #136630 to resolve this.