Skip to content

gh-130655: add tests for dgettext #134594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-130655: add tests for dgettext #134594

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16165b5
gh-134593: add tests for dgettext
alex-semenyuk May 23, 2025
c4fb7ac
fix comments
alex-semenyuk May 23, 2025
77ffbe6
fix comments
alex-semenyuk May 25, 2025
ae5840f
Address comment
alex-semenyuk Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion Lib/test/test_gettext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@


# TODO:
# - Add new tests, for example for "dgettext"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the TODO, since it is still valid (the first part).

It can be updated with the issue number if you wish.

# - Tests should have only one assert.

GNU_MO_DATA = b'''\
Expand Down Expand Up @@ -937,6 +936,42 @@ def test_lazy_import(self):
ensure_lazy_imports("gettext", {"re", "warnings", "locale"})


class DGettextTest(unittest.TestCase):

def setUp(self):
self.localedir = self.enterContext(os_helper.temp_dir())
self.domain = 'gettext_domain'
self.mofile = self.setup_dgettext_test_env()

def setup_dgettext_test_env(self):
os.makedirs(os.path.join(self.localedir, 'en', 'LC_MESSAGES'), exist_ok=True)
mofile = os.path.join(self.localedir, 'en', 'LC_MESSAGES', f'{self.domain}.mo')
with open(mofile, 'wb') as fp:
fp.write(b'\x00\x00\x00\x00')
return mofile

def test_dgettext_found_translation(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Join this one with the other two, these all test the exact same thing (which is well tested above too).

gettext.bindtextdomain(self.domain, self.localedir)
with unittest.mock.patch('gettext.dgettext') as mock_dgettext:
mock_dgettext.return_value = 'test message translation'
result = gettext.dgettext(self.domain, 'test message')
self.assertEqual(result, 'test message translation')

def test_dgettext_missing_translation(self):
gettext.bindtextdomain(self.domain, self.localedir)
result = gettext.dgettext(self.domain, 'missing message')
self.assertEqual(result, 'missing message')

def test_dgettext_non_existent_domain(self):
result = gettext.dgettext('nonexistent_domain', 'test message')
self.assertEqual(result, 'test message')

def test_dgettext_empty_domain(self):
result = gettext.dgettext('', 'test message')
expected = gettext.gettext('test message')
self.assertEqual(result, expected)


if __name__ == '__main__':
unittest.main()

Expand Down
Loading