Skip to content

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented May 24, 2025

@picnixz picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 24, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 8115042 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134624%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 24, 2025
@picnixz picnixz marked this pull request as ready for review May 24, 2025 10:47
@picnixz
Copy link
Member Author

picnixz commented May 25, 2025

I don't understand why test_launcher fails on Windows, so I'll just assume that it's a buildbot issue.

@picnixz picnixz requested a review from colesbury May 25, 2025 08:57
@emmatyping emmatyping added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @emmatyping for commit 442ee6c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134624%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2025
@emmatyping
Copy link
Member

Merged main to re-run tests after the failing buildbot was restarted.

@colesbury colesbury changed the title gh-134586: mark _mi_assert_fail as noreturn, cold and nothrow gh-134586: mark _mi_assert_fail as noreturn, cold and throw May 27, 2025
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please also open a PR upstream?

@picnixz
Copy link
Member Author

picnixz commented May 30, 2025

Would you please also open a PR upstream?
Sure!

@picnixz picnixz merged commit c600310 into python:main May 30, 2025
42 checks passed
@picnixz picnixz deleted the patch/clion/mimalloc-attributes-134586 branch May 30, 2025 12:44
@bedevere-bot

This comment was marked as outdated.

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…row` (python#134624)

We add the following attributes on `_mi_assert_fail` to help IDE introspection:

* `__attribute__((__noreturn__))`
* `__attribute__((cold))`
* `__THROW` (GCC only)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
…row` (python#134624)

We add the following attributes on `_mi_assert_fail` to help IDE introspection:

* `__attribute__((__noreturn__))`
* `__attribute__((cold))`
* `__THROW` (GCC only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants