Skip to content

gh-134733: fix: ast.dump( show_empty=True ) now displays all None values #134743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

gh-134733: fix: ast.dump( show_empty=True ) now displays all None values #134743

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6af9227
fix: ast.dump( show_empty=True ) now displays all `None` values
hunterhogan May 26, 2025
d367af4
NEWS.d file
hunterhogan May 26, 2025
67bc5b2
test_ast.test_dump_show_empty() draft addendum
hunterhogan May 27, 2025
f9106eb
Merge branch 'main' into ast_dump_show_empty
hunterhogan May 27, 2025
2506d2d
Merge branch 'main' into ast_dump_show_empty
hunterhogan May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,11 @@ def _format(node, level=0):
keywords = True
continue
if value is None and getattr(cls, name, ...) is None:
if show_empty:
args.append('%s=%s' % (name, value))
keywords = True
continue
if (
elif (
not show_empty
and (value is None or value == [])
# Special cases:
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2025-05-26-18-20-00.gh-issue-134733.x7Kw9Z.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix :func:`ast.dump` with ``show_empty=True`` to properly display ``None``
values for all AST node fields. Previously, some ``None`` values were not
shown even when ``show_empty=True`` was specified. Patch by hunterhogan.
Loading