Skip to content

gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() #134758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

gh-132775: Always Set __builtins__ In _PyFunction_FromXIData() #134758

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3a8365
Always set __builtins__ in _PyFunction_FromXIData().
ericsnowcurrently May 26, 2025
6c8da8d
Add a missing decref.
ericsnowcurrently May 27, 2025
f254ec7
Use a static str for "__builtins__".
ericsnowcurrently May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Python/crossinterp_data_lookup.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,13 @@ _PyFunction_FromXIData(_PyXIData_t *xidata)
Py_DECREF(code);
return NULL;
}
PyThreadState *tstate = _PyThreadState_GET();
if (PyDict_SetItemString(globals, "__builtins__",
tstate->interp->builtins) < 0)
{
Py_DECREF(globals);
return NULL;
}
PyObject *func = PyFunction_New(code, globals);
Py_DECREF(code);
Py_DECREF(globals);
Expand Down
Loading