feat: Enable Amharic keywords in CPython interpreter #134760
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows you to use Amharic keywords alongside standard English
keywords in Python source code.
Modifications include:
1. **Parser Generator (`Tools/peg_generator/pegen/c_generator.py`):**
* I updated the `_setup_keywords` method to include Amharic keywords in the `reserved_keywords` C array generated for the parser.
* Amharic keywords are mapped to the token types of their corresponding English keywords (e.g., "ከሆነ" maps to the IF token type).
* Keywords are now grouped by their UTF-8 byte length to ensure correct handling of multibyte Amharic characters in the C keyword array.
* The `n_keyword_lists` (max keyword byte length) is also calculated based on UTF-8 byte lengths.
2. **Grammar (`Grammar/python.gram`):**
* I updated parsing rules to include Amharic keywords as alternatives to their English counterparts. For example, `if_stmt` can now be introduced by either 'if' or 'ከሆነ'.
* I applied this change to all keywords specified in the issue, including those for simple and compound statements, expressions, and operators.
* I also updated corresponding "invalid" rules in the grammar for consistency.
To use this feature:
1. Regenerate the parser and related files: `make regen-all`
2. Recompile CPython: `make`
This enables direct execution of Python code written with Amharic keywords, for example:
```python
ተግባር አስላ(ሀ, ለ):
ከሆነ ሀ > ለ:
መልስ ሀ - ለ
አለበለዚያ:
መልስ ለ - ሀ
print(አስላ(5, 10))
```
|
The following commit authors need to sign the Contributor License Agreement:
|
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
This is a non-trivial feature that I don't think it's useful. Please read https://devguide.python.org/ before submitting pull requests with major changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows you to use Amharic keywords alongside standard English keywords in Python source code.
Modifications include:
Parser Generator (
Tools/peg_generator/pegen/c_generator.py):_setup_keywordsmethod to include Amharic keywords in thereserved_keywordsC array generated for the parser.n_keyword_lists(max keyword byte length) is also calculated based on UTF-8 byte lengths.Grammar (
Grammar/python.gram):if_stmtcan now be introduced by either 'if' or 'ከሆነ'.To use this feature:
make regen-allmakeThis enables direct execution of Python code written with Amharic keywords, for example: