gh-134885: zstd: Use Py_XSETREF #134886
Merged
gh-134885: zstd: Use Py_XSETREF #134886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
changed the title
JelleZijlstra
force-pushed
the
zstd-setref
branch
from
0883964 to
3f30ed4
Compare
neonene
reviewed
May 30, 2025
| @@ -1,6 +1,5 @@ | |||
| import ctypes | |||
| import unittest | |||
| import warnings | |||
There was a problem hiding this comment.
Py_XSETREF() LGTM, but this ctypes correction looks like an accident.
There was a problem hiding this comment.
CI was broken on main (the import is unused), and since it's a small change I figured I might as well include it
There was a problem hiding this comment.
It seems like the change is excluded from this PR since f49a07b already applied it, which is good for 3.14.
|
Thanks @JelleZijlstra for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 30, 2025
(cherry picked from commit 45c6c48) Co-authored-by: Jelle Zijlstra <[email protected]>
|
GH-134922 is a backport of this pull request to the 3.14 branch. |
encukou
pushed a commit
that referenced
this pull request
May 30, 2025
(cherry picked from commit 45c6c48) Co-authored-by: Jelle Zijlstra <[email protected]>
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Py_SETREF macro explains, the previous code is theoretically vulnerable to a bug where if the destructor for the previous value of
mod_state->CParameter_typeaccesses this module, it may see a garbage value there.