gh-117888: print failing command when platform triplet detection errors #134905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n errors The build system determines the platform triplet using the C preprocessor. If that fails for whatever reason we presently just report "none" for the triplet and continue until the invalid triplet causes a messy failure down the line. Instead, store any error output, and in the event of a failure send it to stderr and fail immediately with a clear error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build system determines the platform triplet using the C preprocessor. If that fails for whatever reason we presently just report "none" for the triplet and continue until the invalid triplet causes a messy failure down the line.
Instead, store any error output, and in the event of a failure send it to stderr and fail immediately with a clear error message.