[3.14] gh-134768: Fix definition of mt_continue_should_break() (GH-134769)
#134916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onGH-134769) In 121ed71, mt_continue_should_break was changed to be guarded by `Py_DEBUG`, but it's used in `compress_mt_continue_lock_held` with just `assert`, so it needs to be available when `NDEBUG` is undefined too. `Py_DEBUG` implies `NDEBUG` is undefined, so we can check just that. (cherry picked from commit 2f2bee2) Co-authored-by: Sam James <[email protected]> Fixes: 121ed71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 121ed71, mt_continue_should_break
was changed to be guarded by
Py_DEBUG, but it's used incompress_mt_continue_lock_heldwith just
assert, so it needs to be available whenNDEBUGis undefinedtoo.
Py_DEBUGimpliesNDEBUGis undefined, so we can check just that.(cherry picked from commit 2f2bee2)
Co-authored-by: Sam James [email protected]
Fixes: 121ed71