Skip to content

gh-134986: Catch PermissionError when trying to call perf in tests #134987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

gh-134986: Catch PermissionError when trying to call perf in tests #134987

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52a365f
Catch PermissionError when trying to call perf in tests
emmatyping May 31, 2025
f0eff93
Add comment about WSL peculiarity
emmatyping Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_perf_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ def _is_perf_version_at_least(major, minor):
# a commit hash in the version string, like "6.12.9.g242e6068fd5c"
try:
output = subprocess.check_output(["perf", "--version"], text=True)
except (subprocess.CalledProcessError, FileNotFoundError):
except (subprocess.CalledProcessError, FileNotFoundError, PermissionError):
return False
version = output.split()[2]
version = version.split("-")[0]
Expand Down
Loading