Skip to content

gh-135101: When choosing the default simulator device, don't use simctl --set testing #135102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

gh-135101: When choosing the default simulator device, don't use simctl --set testing #135102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iOS/testbed/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ async def async_check_output(*args, **kwargs):
async def select_simulator_device():
# List the testing simulators, in JSON format
Copy link
Contributor

@freakboy3742 freakboy3742 Jun 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# List the testing simulators, in JSON format
# List the testing simulators, in JSON format. Use the full list, not just
# the testing set; on a fresh install (or in CI), the testing set may be empty.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dangit... forgot to merge this suggestion. I've got some other cleanups I need to make in the general area; I'll add it in then.

raw_json = await async_check_output(
"xcrun", "simctl", "--set", "testing", "list", "-j"
"xcrun", "simctl", "list", "-j"
)
json_data = json.loads(raw_json)

Expand Down
Loading