Skip to content

Fix definition of _Py_RemoteDebug_ symbols for static linking #135146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025
Merged

Fix definition of _Py_RemoteDebug_ symbols for static linking #135146

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01bb53d
Fix definition of `_Py_RemoteDebug_` symbols for static linking
zanieb Jun 4, 2025
6fcd698
Add warning ignores
zanieb Jun 4, 2025
629fb91
Use `UNUSED` macro
zanieb Jun 9, 2025
6e5d552
Revert "Add warning ignores"
zanieb Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Python/remote_debug.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@ If you need to add a new function ensure that is declared 'static'.
extern "C" {
#endif

#ifdef __clang__
#define UNUSED __attribute__((unused))
#elif defined(__GNUC__)
#define UNUSED __attribute__((unused))
#elif defined(_MSC_VER)
#define UNUSED __pragma(warning(suppress: 4505))
#else
#define UNUSED
#endif

#if !defined(Py_BUILD_CORE) && !defined(Py_BUILD_CORE_MODULE)
# error "this header requires Py_BUILD_CORE or Py_BUILD_CORE_MODULE define"
#endif
Expand Down Expand Up @@ -131,7 +141,7 @@ _Py_RemoteDebug_FreePageCache(proc_handle_t *handle)
}
}

void
UNUSED static void
_Py_RemoteDebug_ClearCache(proc_handle_t *handle)
{
for (int i = 0; i < MAX_PAGES; i++) {
Expand Down Expand Up @@ -989,7 +999,7 @@ _Py_RemoteDebug_ReadRemoteMemory(proc_handle_t *handle, uintptr_t remote_address
#endif
}

int
UNUSED static int
_Py_RemoteDebug_PagedReadRemoteMemory(proc_handle_t *handle,
uintptr_t addr,
size_t size,
Expand Down
Loading