Skip to content

gh-135177: Raise OverflowError in _Py_call_instrumentation_jump to handle potential integer overflow #135202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-135177: Raise OverflowError in _Py_call_instrumentation_jump to handle potential integer overflow #135202

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e47b73d
gh-135177: Raise OverflowError in _Py_call_instrumentation_jump to ha…
rialbat Jun 6, 2025
d0b499e
gh-135177: Fix error description
rialbat Jun 6, 2025
2eaf739
gh-135177: Updated the error description
rialbat Jun 6, 2025
0d4cfd0
gh-135177: Change `to` variable to a larger type to prevent potential…
rialbat Jun 6, 2025
c7e2e41
gh-135177: Fix compiler warning by casting sizeof(_Py_CODEUNIT) to Py…
rialbat Jun 6, 2025
2b6c6a0
Merge branch 'main' into fix-int-overflow-exception
skirpichev Jun 6, 2025
5b12771
Merge branch 'main' into fix-int-overflow-exception
rialbat Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Python/instrumentation.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,6 +1236,10 @@ _Py_call_instrumentation_jump(
event == PY_MONITORING_EVENT_BRANCH_RIGHT ||
event == PY_MONITORING_EVENT_BRANCH_LEFT);
int to = (int)(dest - _PyFrame_GetBytecode(frame));
if (to <= INT_MAX / (int)sizeof(_Py_CODEUNIT)) {
PyErr_SetString(PyExc_OverflowError, "instruction offset cannot be converted to an integer");
return NULL;
}
PyObject *to_obj = PyLong_FromLong(to * (int)sizeof(_Py_CODEUNIT));
if (to_obj == NULL) {
return NULL;
Expand Down
Loading