Skip to content

gh-135244: use CSPRNG for random UUID node ID #135226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 8, 2025
Merged

gh-135244: use CSPRNG for random UUID node ID #135226

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
69ce4ca
Update uuid.py
LamentXU123 Jun 6, 2025
bc83fa1
Update uuid.py
LamentXU123 Jun 8, 2025
e529546
Update uuid.py
LamentXU123 Jun 8, 2025
4e68299
Update uuid.rst
LamentXU123 Jun 8, 2025
c225ab8
Update uuid.py
LamentXU123 Jun 8, 2025
5006c19
Update Doc/library/uuid.rst
LamentXU123 Jun 8, 2025
b11ea05
Update uuid.py
LamentXU123 Jun 8, 2025
99bedcc
Update Lib/uuid.py
LamentXU123 Jun 8, 2025
0500d06
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 8, 2025
4b8a59e
Update Misc/NEWS.d/next/Library/2025-06-08-10-22-22.gh-issue-135244.Y…
LamentXU123 Jun 8, 2025
c5249d4
update historical note
picnixz Jun 8, 2025
ffe0074
Apply suggestions from code review
picnixz Jun 8, 2025
6241d99
Update Misc/NEWS.d/next/Library/2025-06-08-10-22-22.gh-issue-135244.Y…
picnixz Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Doc/library/uuid.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,8 @@ The :mod:`uuid` module defines the following functions:
positive integers of 48, 12 and 62 bits respectively. If they exceed
their expected bit count, only their least significant bits are kept;
non-specified arguments are substituted for a pseudo-random integer of
appropriate size.
appropriate size. Note that *a*, *b* and *c* are generated by PRNG (not CSPRNG)
so use UUIDv4 if you are generating a token or verification code.

.. versionadded:: 3.14

Expand Down
4 changes: 2 additions & 2 deletions Lib/uuid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,8 +666,8 @@ def _random_getnode():
# counting from 1 being the least significant bit, or 1<<40.
#
# See https://en.wikipedia.org/w/index.php?title=MAC_address&oldid=1128764812#Universal_vs._local_(U/L_bit)
import random
return random.getrandbits(48) | (1 << 40)

return (int.from_bytes(__import__('os').urandom(6), 'big')) | (1 << 40)


# _OS_GETTERS, when known, are targeted for a specific OS or platform.
Expand Down
Loading