Skip to content

gh-135234: improve _hashlib exceptions when reporting an OpenSSL function failure #135250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 9, 2025
Merged

gh-135234: improve _hashlib exceptions when reporting an OpenSSL function failure #135250

merged 19 commits into from
Jun 9, 2025

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Jun 8, 2025 •
edited by bedevere-app bot
Loading

The commits are separated for review purposes but won't compile separately.

@picnixz picnixz requested a review from gpshead as a code owner June 8, 2025 09:28
@bedevere-app bedevere-app bot mentioned this pull request Jun 8, 2025
Closed
@picnixz picnixz marked this pull request as draft June 8, 2025 09:45
@picnixz picnixz marked this pull request as ready for review June 8, 2025 09:54
@picnixz
Copy link
Member Author

picnixz commented Jun 8, 2025

!buildbot FIPS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit e226431 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135250%2Fmerge

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

@picnixz
Copy link
Member Author

picnixz commented Jun 8, 2025 •
edited
Loading

We need a job running the SSL tests with solely OpenSSL 1.1.1, because it appears that sometimes there is no error on 3.0 but there are some on 1.1.1.

@picnixz
Copy link
Member Author

picnixz commented Jun 8, 2025

!buildbot FIPS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 7201e0a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135250%2Fmerge

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

This was referenced Jun 8, 2025
Merged
Merged
@picnixz
Copy link
Member Author

picnixz commented Jun 8, 2025

!buildbot FIPS only

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 76c7dd2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135250%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

gpshead
gpshead approved these changes Jun 8, 2025
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@picnixz picnixz self-assigned this Jun 8, 2025
@picnixz picnixz merged commit 83b94e8 into python:main Jun 9, 2025
39 checks passed
@picnixz picnixz deleted the feat/hashlib/smart-exceptions-135234 branch June 9, 2025 07:13
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@picnixz @lkollar
pythongh-135234: improve _hashlib exceptions when reporting an Open…
05412cb 
…SSL function failure (python#135250)

- Refactor `get_openssl_evp_md_by_utf8name` error branches.
- Refactor `HASH.{digest,hexdigest}` computations.
- Refactor `_hashlib_HASH_copy_locked` and `locked_HMAC_CTX_copy`.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@picnixz @Pranjal095
pythongh-135234: improve _hashlib exceptions when reporting an Open…
d34d116 
…SSL function failure (python#135250)

- Refactor `get_openssl_evp_md_by_utf8name` error branches.
- Refactor `HASH.{digest,hexdigest}` computations.
- Refactor `_hashlib_HASH_copy_locked` and `locked_HMAC_CTX_copy`.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz @taegyunkim
pythongh-135234: improve _hashlib exceptions when reporting an Open…
297bcef 
…SSL function failure (python#135250)

- Refactor `get_openssl_evp_md_by_utf8name` error branches.
- Refactor `HASH.{digest,hexdigest}` computations.
- Refactor `_hashlib_HASH_copy_locked` and `locked_HMAC_CTX_copy`.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@picnixz @Agent-Hellboy
pythongh-135234: improve _hashlib exceptions when reporting an Open…
f9de525 
…SSL function failure (python#135250)

- Refactor `get_openssl_evp_md_by_utf8name` error branches.
- Refactor `HASH.{digest,hexdigest}` computations.
- Refactor `_hashlib_HASH_copy_locked` and `locked_HMAC_CTX_copy`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@picnixz picnixz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz @bedevere-bot @gpshead