Skip to content

gh-133390: Support SQL keyword completion for sqlite3 CLI (#133393) #135292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2025
Merged

gh-133390: Support SQL keyword completion for sqlite3 CLI (#133393) #135292

merged 5 commits into from
Jun 12, 2025

Conversation

@encukou
Copy link
Member

@encukou encukou commented Jun 9, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 9, 2025
Closed
@encukou
Copy link
Member Author

encukou commented Jun 9, 2025

!buildbot aarch64.Fedora.Stable.PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 10f822b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135292%2Fmerge

The command will test the builders whose names match following regular expression: aarch64.Fedora.Stable.PR

The builders matched are:

  • aarch64 Fedora Stable PR

@encukou
Copy link
Member Author

encukou commented Jun 9, 2025

!buildbot aarch64.Fedora.Stable.PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit bd6a870 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135292%2Fmerge

The command will test the builders whose names match following regular expression: aarch64.Fedora.Stable.PR

The builders matched are:

  • aarch64 Fedora Stable PR

@encukou
Copy link
Member Author

encukou commented Jun 9, 2025

!buildbot AMD64.Ubuntu.Shared.PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit bd6a870 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135292%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.Ubuntu.Shared.PR

The builders matched are:

  • AMD64 Ubuntu Shared PR

@encukou
Copy link
Member Author

encukou commented Jun 10, 2025

!buildbot AMD64.Ubuntu.Shared.PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 3d9721a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135292%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.Ubuntu.Shared.PR

The builders matched are:

  • AMD64 Ubuntu Shared PR

@encukou
Copy link
Member Author

encukou commented Jun 11, 2025

!buildbot AMD64.Ubuntu.Shared.PR|aarch64.Fedora.Stable.PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit f1fa6c7 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135292%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.Ubuntu.Shared.PR|aarch64.Fedora.Stable.PR

The builders matched are:

  • AMD64 Ubuntu Shared PR
  • aarch64 Fedora Stable PR

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 11, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit f1fa6c7 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135292%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 11, 2025
@encukou
Copy link
Member Author

encukou commented Jun 12, 2025

Alright, looks like we now pass everywhere!

  • In some configurations, Python needs some env variables to start, so the environment needs to be updated rather than replaced.
  • The show-all-if-ambiguous readline setting means that alternatives are listed after a single tab, so with \t\t they got listed twice.

@encukou encukou merged commit e7a3c20 into python:main Jun 12, 2025
121 of 123 checks passed
@encukou encukou deleted the reapply-62b3d2d branch June 12, 2025 14:28
erlend-aasland
erlend-aasland reviewed Jun 13, 2025
View reviewed changes
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@encukou @tanloong @lkollar
pythongh-133390: Support SQL keyword completion for sqlite3 CLI (pyth…
6767d02 
…onGH-133393) (pythonGH-135292)

Co-authored-by: Tan Long <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou @tanloong @Pranjal095
pythongh-133390: Support SQL keyword completion for sqlite3 CLI (pyth…
23f7b0e 
…onGH-133393) (pythonGH-135292)

Co-authored-by: Tan Long <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou @tanloong @taegyunkim
pythongh-133390: Support SQL keyword completion for sqlite3 CLI (pyth…
21bea1b 
…onGH-133393) (pythonGH-135292)

Co-authored-by: Tan Long <[email protected]>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@encukou @tanloong @Agent-Hellboy
pythongh-133390: Support SQL keyword completion for sqlite3 CLI (pyth…
c2661a6 
…onGH-133393) (pythonGH-135292)

Co-authored-by: Tan Long <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@encukou @bedevere-bot @erlend-aasland @tanloong