gh-135329: prevent infinite traceback loop on Ctrl-C under external p… #135366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal programs When running Python REPL under another program (e.g., strace) and pressing Ctrl-C, termios raises `EIO` during terminal state restoration, causing infinite exception tracebacks. This patch catches `termios.error` with `errno.EIO` in `reader.prepare()` to avoid recursive failure loops when restoring console state.
Contributor
Contributor
Author
|
@cmaloney Sorry about that, I completely forgot. Yes, I’m planning to finish it soon — will get back to it in the near future. |
Contributor
|
We went with #138133 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.