gh-135371: Fix asyncio task awaited_by semantics in remote debugging #135372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gging The awaited_by list in get_all_awaited_by() was incorrectly showing the awaiter's call stack instead of the current task's call stack. This made the output confusing and incorrect. This change adds a new parse_current_task_with_awaiter() function that correctly extracts the current task's own call stack (where it's executing) and the awaiter's task ID (who is waiting for this task).
pablogsal
requested review from
1st1,
ambv,
asvetlov,
kumaraditya303 and
willingc
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The awaited_by list in get_all_awaited_by() was incorrectly showing the
awaiter's call stack instead of the current task's call stack. This made
the output confusing and incorrect.
This change adds a new parse_current_task_with_awaiter() function that
correctly extracts the current task's own call stack (where it's
executing) and the awaiter's task ID (who is waiting for this task).
get_all_awaited_by()shows incorrect call stacks in awaited_by relationships #135371