Skip to content

gh-135380: enhance critical section held assertions #135381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2025
Merged

gh-135380: enhance critical section held assertions #135381

merged 2 commits into from
Jun 20, 2025

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jun 11, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 11, 2025
Closed
vstinner
vstinner reviewed Jun 11, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity reviewed Jun 11, 2025
View reviewed changes
@kumaraditya303 kumaraditya303 requested a review from vstinner June 12, 2025 11:14
@vstinner
Copy link
Member

I kept it similar to mutex lock held function which uses Py_DEBUG not NDEBUG.

IMO it's worth it to replace #ifdef Py_DEBUG with #ifndef NDEBUG to support building Python with assertions in release mode: https://docs.python.org/dev/using/configure.html#cmdoption-with-assertions But I suggest doing that in a follow-up PR.

vstinner
vstinner reviewed Jun 12, 2025
View reviewed changes
@kumaraditya303 kumaraditya303 merged commit a8ec511 into python:main Jun 20, 2025
42 checks passed
@kumaraditya303 kumaraditya303 deleted the critical branch June 20, 2025 17:13
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@kumaraditya303 @Pranjal095
pythongh-135380: enhance critical section held assertions (python#135381
e74af08 
)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@kumaraditya303 @taegyunkim
pythongh-135380: enhance critical section held assertions (python#135381
9b8d918 
)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@kumaraditya303 @Agent-Hellboy
pythongh-135380: enhance critical section held assertions (python#135381
d6fe569 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@colesbury colesbury colesbury approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303 @vstinner @colesbury @ZeroIntensity