gh-135450: Remove assertion in _PyCode_CheckNoExternalState
#135466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZeroIntensity, FYI, I held off on merging this as I figured you could do it. 😄 |
|
@vstinner has control over my green button at the moment 😄. I think he wants me to merge some more trivial changes to help me adjust before merging things like this. |
|
Thanks @ZeroIntensity for the PR, and @ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 18, 2025
…ythongh-135466) The assertion reflected a misunderstanding of situations where "hidden" variables might exist, namely generator expressions and comprehensions. (cherry picked from commit 15f2bac) Co-authored-by: Peter Bierma <[email protected]>
|
GH-135694 is a backport of this pull request to the 3.14 branch. |
ericsnowcurrently
pushed a commit
that referenced
this pull request
Jun 18, 2025
…h-135694) The assertion reflected a misunderstanding of situations where "hidden" variables might exist, namely generator expressions and comprehensions. (cherry picked from commit 15f2bac, AKA gh-135466) Co-authored-by: Peter Bierma <[email protected]>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Jun 19, 2025
…ythongh-135466) The assertion reflected a misunderstanding of situations where "hidden" variables might exist, namely generator expressions and comprehensions.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…ythongh-135466) The assertion reflected a misunderstanding of situations where "hidden" variables might exist, namely generator expressions and comprehensions.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…ythongh-135466) The assertion reflected a misunderstanding of situations where "hidden" variables might exist, namely generator expressions and comprehensions.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…ythongh-135466) The assertion reflected a misunderstanding of situations where "hidden" variables might exist, namely generator expressions and comprehensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip newsbecause_interpretersisn't public.